Side panel sizing + vault-by-default + store sync; pending-chip hints - #71
Merged
Conversation
…tore/column sync Kate's live findings on the vault-in-side-panel move: - The tabs column inherited the review panel's flex-fill sizing and swallowed the window. It now owns a persisted width (panelColumn, default 400px) with a start-edge resize handle down to 240px; the chat takes the remainder (the old chat-edge handle is gone). - An open column with nothing to show sat on 'Select a file to open'. It now fills with the vault by default, and closing the vault tab with nothing else open closes the column too. - Closing the column desynced the vaultPanel store, so the titlebar button's next press toggled an invisible state — 'the button does nothing'. Column close now closes the store (reproduced and verified via Playwright probe). - Pending rail chips (Pulse/Device) read as broken dead buttons — they now carry title/aria explaining what creates them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The sync effect tracked the tab store it writes, so tabs().open() re-triggered it until the stack blew (RangeError caught via Playwright pageerror during vault toggling). on() scopes tracking to vaultPanel.opened() alone, with idempotence guards on the tab ops. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-follow to #68 from Kate's live testing:
title/aria-labelexplaining what creates them — an unexplained dead chip reads as a bug.Verification: typecheck clean, 442 app tests green, lint 0 errors, plus headless Playwright probes against the running app for the sync bug and both titlebar buttons.
🤖 Generated with Claude Code